[Security Solution] Use Dashboard name in the page title #155381
Merged
+32
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semd
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
semd
commented
Apr 20, 2023
| }, | ||
| ]; | ||
| const breadcrumbName = params?.state?.dashboardName; | ||
| if (breadcrumbName) { |
There was a problem hiding this comment.
Using params.detailName was causing a change (id -> name) in the last breadcrumb when the dashboard is finally loaded.
I checked other places, the convention seems to be to show the last "name" breadcrumb only when the information is loaded.
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @semd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
issue: #152955
follow up of #153040
These changes make the dashboard name to be displayed in the page title, as requested by @paulewing
Screenshots